[PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member
Shafik Yaghmour via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 5 17:07:38 PDT 2022
shafik accepted this revision.
shafik added a comment.
LGTM
================
Comment at: lldb/test/API/lang/cpp/const_static_integral_member/main.cpp:39
const static auto char_min = std::numeric_limits<char>::min();
const static auto uchar_min = std::numeric_limits<unsigned char>::min();
----------------
We use `signed char` for the max case but `char` for the min case. Maybe we need a max using `char` and a min using `signed char`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135170/new/
https://reviews.llvm.org/D135170
More information about the cfe-commits
mailing list