[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

[Zixu Wang via Phabricator via cfe-commits]

zixuw added a subscriber: QuietMisdreavus.
zixuw added a comment.

In D134813#3836836 <https://reviews.llvm.org/D134813#3836836>, @aaron.ballman wrote:

>> I'd guess we need some kind of change to CommentXML and ExtractAPI, but I don't know enough to be sure what it should be.
>
> Ping @dang @zixuw and @dexonsmith for questions about how to handle ExtractAPI changes, and @gribozavr for questions about CommentXML

Thanks for the heads up! Looking.

At a glance it seems that ExtractAPI would like to fall back to the original formats to not break downstream tooling. But not sure if it's fine because it's still consistent. As far as I can tell this only affects anonymous `TagDecl`s. @QuietMisdreavus thoughts?

IMO we would still want to keep the ExtractAPI outputs unchanged if it's easy enough to do. We're using `getName()/getQualifiedNameAsString()` for names and `index::generateUSRForDecl()` for USRs. Is there a 'policy' or some alternatives to use? Or is the location info now part of the 'correct' format for USRs (seems a bit weird to see that as part of the USR)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134813/new/

https://reviews.llvm.org/D134813