[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 09:33:07 PDT 2022


erichkeane added inline comments.


================
Comment at: clang/include/clang/Sema/SemaConcept.h:51
+      // QualType of constrained template template parameter is not the same as
+      // its tailing version, so give it a pass here.
+      if (LHS.getKind() == TemplateArgument::Type &&
----------------
what do you mean by 'tailing' here?


================
Comment at: clang/include/clang/Sema/SemaConcept.h:58
+            cast<TemplateTypeParmType>(RHS.getAsType())->getIndex())
+          continue;
+      }
----------------
What exactly is going on here?  I would expect the 'AdjustConstraintDepth' work to have already made these basically equal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134128/new/

https://reviews.llvm.org/D134128



More information about the cfe-commits mailing list