[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

Steve Canon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 08:25:55 PDT 2022


scanon added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:607
+ T __builtin_elementwise_cos(T x)            return the ratio of the adjacent side length over the            floating point types
+                                             hypoteneuse side length, given the angle x in radians            
  T __builtin_elementwise_floor(T x)          return the largest integral value less than or equal to x        floating point types
----------------
craig.topper wrote:
> hypotenuse*
As long as we're tweaking descriptions, please just call these "cosine" and "sine" instead of a cumbersome ratio description. "The cosine of x interpreted as an angle in radians" or similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135011/new/

https://reviews.llvm.org/D135011



More information about the cfe-commits mailing list