[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 05:36:14 PDT 2022


aaron.ballman added a comment.

I'm not comfortable giving the final LG but the changes here look reasonable to me.



================
Comment at: clang/lib/CodeGen/CGStmt.cpp:829-831
+      CGM.getCodeGenOpts().OptimizationLevel) {
     LH = Stmt::getLikelihood(S.getThen(), S.getElse());
+  }
----------------
You can drop the braces here per the coding standard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134456/new/

https://reviews.llvm.org/D134456



More information about the cfe-commits mailing list