[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 5 04:28:52 PDT 2022
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D135257
Files:
clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp
Index: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp
===================================================================
--- clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp
+++ clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp
@@ -248,6 +248,13 @@
// FIXME: Support extraction from templated functions.
if (Func->isTemplated())
return nullptr;
+ for (const auto *S : Func->getBody()->children()) {
+ // During apply phase, we perform semantic analysis (e.g. figure out
+ // what variables requires hoisting). We cannot perform those when the
+ // body has invalid statements, so fail up front.
+ if (!S)
+ return nullptr;
+ }
return Func;
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135257.465343.patch
Type: text/x-patch
Size: 767 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221005/f7c12ea6/attachment.bin>
More information about the cfe-commits
mailing list