[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 17:37:32 PDT 2022


sammccall added a comment.

My first take on this was to keep track in various ways of whether GC was required (statically known at callsite, or have builder track whether symbols were overwritten).
However these failed to identify a bunch of cases where the arena wasn't shrinking, and this seems much simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135231/new/

https://reviews.llvm.org/D135231



More information about the cfe-commits mailing list