[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: clang/test/CodeGen/amdgcn-control-constants.c:8
+
+// GFX90A: @__oclc_daz_opt = linkonce_odr hidden local_unnamed_addr addrspace(4) constant i8 0, align 1
+// GFX90A: @__oclc_wavefrontsize64 = linkonce_odr hidden local_unnamed_addr addrspace(4) constant i8 1, align 1
----------------
jhuber6 wrote:
> yaxunl wrote:
> > yaxunl wrote:
> > > need an OpenCL test for -cl-denorms-are-zero
> > still missing this test, and some other tests for -cl-* options as commented below.
> > 
> > Also, missing a HIP test for -ffast-math
> The cc1 math options tested individually should be enabled by `-ffast-math`.
Since we cannot test -ffast-math directly, can we add a driver test to ensure we are not missing any -cc1 options needed by the control variables when -ffast-math is specified for the driver? Thanks.

Also, the -cl-* options are -cc1 options. We need to test them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130096/new/

https://reviews.llvm.org/D130096