[PATCH] D135115: [clang-format] update --files help description

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 08:32:20 PDT 2022


probinson added inline comments.


================
Comment at: clang/docs/ClangFormat.rst:72-73
                                      Used only with --dry-run or -n
-    --files=<string>               - Provide a list of files to run clang-format
+    --files=<string>               - Accept a list of response files (Deprecated. Use
+                                     'clang-format @file' if possbile).
     -i                             - Inplace edit <file>s, if specified.
----------------
MyDeveloperDay wrote:
> if you google "response files" you don't get anything that leads to understand what they are. I understand what it means but I'm not convinced others who have not come across it before will. I don't personally think this change adds anything.
I was thinking something like this.  In particular, call the argument a "filename" and then say what it should look like.  The old description with a "string" argument reads like it might want to be 
`--files=file1,file2,file3` 
or something like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135115/new/

https://reviews.llvm.org/D135115



More information about the cfe-commits mailing list