[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 06:08:35 PDT 2022


hans created this revision.
hans added a reviewer: thakis.
Herald added a subscriber: mstorsjo.
Herald added a project: All.
hans requested review of this revision.
Herald added a project: clang.

Previously we were stripping these normally inherited attributes during explicit specialization. However for class template member functions (but not function templates), MSVC keeps the attribute.

This makes Clang match that behavior, and fixes GitHub issue #54717


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135154

Files:
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaTemplate.cpp
  clang/test/CodeGenCXX/dllexport-members.cpp
  clang/test/CodeGenCXX/dllimport-members.cpp
  clang/test/SemaCXX/dllimport.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135154.464984.patch
Type: text/x-patch
Size: 7817 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221004/32476335/attachment.bin>


More information about the cfe-commits mailing list