[PATCH] D135115: [clang-format] update --files help description

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 05:39:14 PDT 2022


MyDeveloperDay added inline comments.


================
Comment at: clang/docs/ClangFormat.rst:29
 
   USAGE: clang-format [options] [<file> ...]
 
----------------
if response files are so common place why not say it here 

`clang-format [options] [@file]`

I personally don't believe we need to document how a shell works


================
Comment at: clang/docs/ClangFormat.rst:72
                                      Used only with --dry-run or -n
-    --files=<string>               - Provide a list of files to run clang-format
+    --files=<string>               - Accept a list of response files (Deprecated. Use
+                                     'clang-format @file' if possbile).
----------------
if you google "response files" you don't get anything that leads to understand what they are. I understand what it means but I'm not convinced others who have not come across it before will. I don't personally think this change adds anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135115/new/

https://reviews.llvm.org/D135115



More information about the cfe-commits mailing list