[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Tue Oct 4 05:31:43 PDT 2022

aaron.ballman added a subscriber: mizvekov.
aaron.ballman added a comment.

In D134813#3826991 <https://reviews.llvm.org/D134813#3826991>, @aaron.ballman wrote:

> The clangd test failure found by precommit CI is stumping me as to how to resolve it. @sammccall -- can you help me out? The issue is that the test is expecting no name but now we're printing more information, but that information includes a file path which may differ between machines.

Ping @sammccall. FWIW, I found that the failing part of this test was change somewhat recently in https://github.com/llvm/llvm-project/commit/15f3cd6bfc670ba6106184a903eb04be059e5977 to add the markings to print the name of this class, so also pinging @mizvekov to see if this test coverage is necessary (another way to solve the issue is to stop trying to read the name of the unnamed class in the unit test).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134813/new/

https://reviews.llvm.org/D134813