[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

[serge via Phabricator via cfe-commits]

serge-sans-paille added a comment.

Thanks for working on this! A few nits  inline



================
Comment at: clang/include/clang/Basic/LangOptions.h:369
+  enum class StrictFlexArraysLevelKind {
+    /// Any trailing array memeber is a FAM.
+    Default = 0,
----------------
typo: member


================
Comment at: clang/include/clang/Basic/LangOptions.h:373
+    OneZeroOrIncomplete = 1,
+    /// Any trailing array member of undefined or 0 is a FAM.
+    ZeroOrIncomplete = 2,
----------------
+ size


================
Comment at: clang/include/clang/Basic/LangOptions.h:375
+    ZeroOrIncomplete = 2,
+    /// Any trailing array member of undefined or 0 is a FAM.
+    Incomplete = 3,
----------------
I think you meant `Any trailing array member of undefined size is a FAM`


================
Comment at: clang/include/clang/Driver/Options.td:1155
+  NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">,
+  NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "Incomplete"]>,
   HelpText<"Enable optimizations based on the strict definition of flexible arrays">,
----------------
Note that this depends on https://reviews.llvm.org/D134902 to have the "Incomplete" support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135107/new/

https://reviews.llvm.org/D135107