[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 15:39:10 PDT 2022


efriedma added a comment.

I think we want to test both that the warning isn't triggered when --target isn't specified, and that the warning is triggered when --target is specified.



================
Comment at: clang/test/Driver/cl-options.c:787
+// ARM64EC: "-triple" "arm64ec-pc-windows-msvc19.20.0"
+// ARM64EC-NOT: /arm64EC has been overridden by specified target
+
----------------
I think the ARM64EC-NOT might be in the wrong place?  I think the warning would show up before the final command line, not after it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134788/new/

https://reviews.llvm.org/D134788



More information about the cfe-commits mailing list