[PATCH] D135011: Add sin and cos llvm builtins

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 14:46:44 PDT 2022


rjmccall added a comment.

The titled of this patch should be something like "Add __builtin_elementwise_sin and __builtin_elementwise_cos".

Can you explain why this uses a new builtin name instead of overloading the existing builtins to work on vectors?  I can imagine reasons why, but I think it needs to be explained.  I can't imagine `cos` and `sin` not being element-wise operations on a vector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135011/new/

https://reviews.llvm.org/D135011



More information about the cfe-commits mailing list