[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 14:37:09 PDT 2022


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaCast.cpp:2999
+      Self.Diag(SrcExpr.get()->getExprLoc(), diag::err_nullptr_cast)
+          << 0 /*nullptr to type*/ << DestType;
+      SrcExpr = ExprError();
----------------
Curious why put the comment after? When we use `butprone-argument-comment` for function parameters we put them before. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135099/new/

https://reviews.llvm.org/D135099



More information about the cfe-commits mailing list