[PATCH] D135011: Add sin and cos llvm builtins

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 10:32:17 PDT 2022


erichkeane added a comment.

Please clarify the commit message (review description) to better explain what it is you're doing here, the purpose/etc as well as the documentation requested by @fhahn

This also needs release notes.



================
Comment at: clang/test/SemaCXX/builtins-elementwise-math.cpp:76
+}
\ No newline at end of file

----------------
Nit: please make sure this newline is present.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135011/new/

https://reviews.llvm.org/D135011



More information about the cfe-commits mailing list