[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

In D135076#3830914 <https://reviews.llvm.org/D135076#3830914>, @MaskRay wrote:

> Single-dash long options starting with `-o` conflict with the short option `-o` so I am unsure I like this direction.
>
>> However, if a user uses a single dash it will instead name a file 'ffload-arch' for example.
>
> That's intended. A user should be able to specify an output name `ffload-arch` with `-offload-arch`.
>
>> This is similar to many other driver arguments beginning with -o.
>
> What options?



  ./bin/clang --help-hidden | grep "  \-o"
    -objcmt-allowlist-dir-path=<value>
    -objcmt-atomic-property Make migration to 'atomic' properties
    -objcmt-migrate-all     Enable migration to modern ObjC
    -objcmt-migrate-annotation
    -objcmt-migrate-designated-init
    -objcmt-migrate-instancetype
    -objcmt-migrate-literals
    -objcmt-migrate-ns-macros
    -objcmt-migrate-property-dot-syntax
    -objcmt-migrate-property
    -objcmt-migrate-protocol-conformance
    -objcmt-migrate-readonly-property
    -objcmt-migrate-readwrite-property
    -objcmt-migrate-subscripting
    -objcmt-ns-nonatomic-iosonly
    -objcmt-returns-innerpointer-property
    -objcmt-whitelist-dir-path=<value>
    -object-file-name=<file>
    -o <file>               Write output to <file>

The alternative is to at least warn if users write `-offload...` rather than `--offlaod...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135076/new/

https://reviews.llvm.org/D135076