[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Driver/debug-options-aranges.c:1
+// REQUIRES: lld
+
----------------
Remove `// REQUIRES: lld`


================
Comment at: clang/test/Driver/debug-options-aranges.c:3
+
+// Check that the linker plugin will get -generate-arange-section
+//
----------------
Optional: End full sentences with a period. Some directories use the convention that non-RUN-non-CHECK lines use `///` as the comment marker. The idea is to make comments stand out and foster possible future lit/FileCheck improvement that check unused prefixes.


================
Comment at: clang/test/Driver/debug-options-aranges.c:4
+// Check that the linker plugin will get -generate-arange-section
+//
+// RUN: %clang -### -g --target=x86_64-linux -flto      -gdwarf-aranges %s 2>&1 | FileCheck %s
----------------
This otherwise empty line is not useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133092/new/

https://reviews.llvm.org/D133092