[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

[serge via Phabricator via cfe-commits]

serge-sans-paille marked an inline comment as done.
serge-sans-paille added inline comments.


================
Comment at: clang/lib/AST/Expr.cpp:225
+
+  } else if (!Context.getAsIncompleteArrayType(getType()))
+    return false;
----------------
tschuett wrote:
> Could this be an early exit?
I don't think so, the first branch is more likely to trigger than this one, so keeping it here seems a better choice (and it's conservative wrt. previous implementation)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134791/new/

https://reviews.llvm.org/D134791