[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

Thorsten via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 1 04:34:34 PDT 2022


tschuett added inline comments.


================
Comment at: clang/lib/AST/Expr.cpp:225
+
+  } else if (!Context.getAsIncompleteArrayType(getType()))
+    return false;
----------------
Could this be an early exit?


================
Comment at: clang/lib/AST/Expr.cpp:267
+
+    if (FD->getParent()->isUnion())
+      return true;
----------------
Could this be an early exit by moving it up?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134791/new/

https://reviews.llvm.org/D134791



More information about the cfe-commits mailing list