[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

Thanks for the testcases!

The indirect one is particularly interesting, and suggests that we may want a "seen decls" set (similar to `SeenTemplates` here <https://searchfox.org/llvm/rev/412141663cfcc7883c24217bcb88780e4572543b/clang-tools-extra/clangd/AST.cpp#944>) in the `kindForDecl()` recursion?

(I'd move the check into `resolveUsingValueDecl()`, but that goes against the grain of putting the more thorough check in the caller -- or should we do both?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134827/new/

https://reviews.llvm.org/D134827