[PATCH] D134921: [HLSL] add cos library function

Xiang Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 16:25:05 PDT 2022


python3kgae added a comment.

In D134921#3828545 <https://reviews.llvm.org/D134921#3828545>, @bob80905 wrote:

> - lower cos to llvm

This will affect things outside HLSL.
Please create a new PR without HLSL related part. Sorry I didn't make things clear before :(.

You can copy what https://github.com/llvm/llvm-project/commit/8680f951c21e675a110e79c9b8dc59bb94290b01 did when adding __builtin_elementwise_ceil
Also need to modify docs like https://github.com/llvm/llvm-project/commit/025988ded6b2a57022dbf9775f35a1a933584bfa


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134921/new/

https://reviews.llvm.org/D134921



More information about the cfe-commits mailing list