[PATCH] D134976: [clang][deps] Abolish FileManager sharing
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 30 11:02:41 PDT 2022
jansvoboda11 created this revision.
jansvoboda11 added reviewers: benlangmuir, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch removes the ability of a dependency scanning worker to share a `FileManager` instance between individual scans. It's not sound and doesn't provide performance benefits (due to the underlying caching VFS).
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D134976
Files:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h
clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h
clang/lib/Tooling/DependencyScanning/DependencyScanningService.cpp
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
clang/test/ClangScanDeps/modulemap-via-vfs.m
clang/test/ClangScanDeps/subframework_header_dir_symlink.m
clang/test/ClangScanDeps/symlink.cpp
clang/tools/clang-scan-deps/ClangScanDeps.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134976.464329.patch
Type: text/x-patch
Size: 9927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220930/fac794db/attachment-0001.bin>
More information about the cfe-commits
mailing list