[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

[Martin Sebor via Phabricator via cfe-commits]

msebor added a comment.

Thanks for the heads up!  My only general comment is that unless this change has no externally observable effect I'd suggest adding tests.  (Otherwise, noting it has no such effect would be helpful.)  When I'm not familiar with the code (and often even what I am) I usually look for tests to understand the impact of a change.



================
Comment at: clang/include/clang/AST/Expr.h:526
 
+  /// Check whether this array fits the idiom of a flexible array member,
+  /// depending on the value of -fstrict-flex-array.
----------------
I was a little unsure what "this array" means in the context of an expression but after reading the code I think the intent of the function is to "Return true if this expression designates an array fits the idiom of a flexible array member..."  If I have that right then that's what I would suggest to change the comment to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134791/new/

https://reviews.llvm.org/D134791