[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

Fri Sep 30 09:59:48 PDT 2022

erichkeane added a comment.

In D134885#3827535 <https://reviews.llvm.org/D134885#3827535>, @royjacobson wrote:

> In D134885#3827479 <https://reviews.llvm.org/D134885#3827479>, @shafik wrote:
>
>> In D134885#3826335 <https://reviews.llvm.org/D134885#3826335>, @royjacobson wrote:
>>
>>> Apparently some of the workers crashed with the test - https://lab.llvm.org/buildbot/#/builders/216/builds/10556, but I couldn't reproduce this locally. @shafik any idea why the diagnostics might change? :/
>>
>> I can't see what is going on here either. It looks like this is a windows PS5 bot. If you have access to a windows machine it might be worth trying a windows release w/ asserts build to see if it reproduces there.
>
> Ahhh, that exaplains it. The PlayStation targets didn't switch their default standard version to C++17, and using --std=c++14 will indeed reproduce the warnings. Some C++17 aggregate initialization changes, I guess. Thank you!

Hah, wow!  Good catch!  I'd not known about the PS not changing defaults, but I DID have the DeclCXX.cpp 'setBases' function up on my screen that set that aggregate and was like, "huh... this is interesting, but I don't see how that applies here".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134885/new/

https://reviews.llvm.org/D134885