[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

Fri Sep 30 08:40:52 PDT 2022

royjacobson added a comment.

In D134885#3827383 <https://reviews.llvm.org/D134885#3827383>, @erichkeane wrote:

> In D134885#3826335 <https://reviews.llvm.org/D134885#3826335>, @royjacobson wrote:
>
>> Apparently some of the workers crashed with the test - https://lab.llvm.org/buildbot/#/builders/216/builds/10556, but I couldn't reproduce this locally. @shafik any idea why the diagnostics might change? :/
>
> I have no idea where that warning comes from.  That shouldn't happen on ANY machine, since it is a public member (a is), not a private one (which should cause the diagnostic).  Is that the only bot with this problem?
>
> I don't know what the 'sie' build is... but it gets me wondering if that diagnostic is getting an uninitialized version of "VerifyOnly" somewhere?  It seems to me that it should be suppressing that diagnostic (if that is what VerifyOnly means here?)?
>
> It IS bizarre to me that this crash would be noticed by something that DIDN'T try to evaluate that diagnostic though, since the ICE is on that code path.

Hmmm, uninitialized access might explain why it's runner dependent. I'll try and see if I can run it through USan.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134885/new/

https://reviews.llvm.org/D134885