[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

[Jean Perier via Phabricator via cfe-commits]

jeanPerier accepted this revision.
jeanPerier added a comment.
This revision is now accepted and ready to land.

The lowering part looks good to me (I only have a minor comment inlined about a header used in lowering).



================
Comment at: flang/include/flang/Runtime/environment-defaults.h:19
+  std::string defaultValue;
+};
+
----------------
I think this header may better belong to Semantics (or even Lower since it is only used there) in the sense that it does not define a data structure that is used at runtime, but it defines a data structure so that we can keep track of some default environment value during compilation (It is not a huge deal, but I am a little bit wary of seeing std::string in Fortran::runtime while the runtime is meant to be free of the C++ runtime).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130513/new/

https://reviews.llvm.org/D130513