[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

Fri Sep 30 05:40:33 PDT 2022

aaron.ballman added a comment.

In D134671#3824868 <https://reviews.llvm.org/D134671#3824868>, @MaskRay wrote:

> In D134671#3824672 <https://reviews.llvm.org/D134671#3824672>, @aaron.ballman wrote:
>
>> In D134671#3824644 <https://reviews.llvm.org/D134671#3824644>, @nickdesaulniers wrote:
>>
>>> I don't think it's an issue for us to work around downstream, but this did regress support for `-mabi=ms` used in UEFI related build scripts.
>>> https://github.com/ClangBuiltLinux/linux/issues/1725
>>> Noting it in case others find their way here via bisection. Thanks to @nathanchance for the report.
>>
>> If that's intentional, should we call this out as a potentially breaking change in the release notes and post an announcement?
>
> I feel that this is still a minor issue. If we consider this as potentially breaking change, then we'd add many many driver changes as potentially breaking.
> I think we should wait for more evidence.

Perfect, thank you for verifying! (That's my intuition as well, but I was on the fence and wondering if my intuition was wrong.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134671/new/

https://reviews.llvm.org/D134671