[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

Fri Sep 30 02:40:13 PDT 2022

hokein added a comment.

>>> @hokein or I will try to find time to take a stab at this.
>>
>> Awesome, please keep me in the loop.
>
> Will do!

https://reviews.llvm.org/D134942 is my attempt.

In D20401#2770059 <https://reviews.llvm.org/D20401#2770059>, @nickdesaulniers wrote:

>> I discussed this bug with Argyrios off-list, who lgtm'd on the condition that it doesn't introduce a performance regression.
>
> Well, I'd say it's a performance regression, though perhaps reported 5 years too late.

This patch does increase the number of SLocEntries. At least for SemaExpr.cpp, prior this patch it is ~298K, after this patch it is ~315K (~5% increase).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D20401/new/

https://reviews.llvm.org/D20401