[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 29 23:09:54 PDT 2022


mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: clang/test/Driver/config-file3.c:176
 //
-// SHORT-NAME: Configuration file: {{.*}}/testdmode/qqq.cfg
-// SHORT-NAME: -Werror
-// SHORT-NAME-NOT: -Wundefined-func-template
+// FULL3-NOT: Configuration file:
+// FULL3: Configuration file: {{.*}}/testdmode/clang++.cfg
----------------
MaskRay wrote:
> This pattern can be replaced with FileCheck's --implicit-check-not='Configuration file:'
Thanks. I've only read your comment after pushing but I've done that now, and it is a definite improvement:

```
[main 78c97b46e6e0] [clang] [test] Use --implicit-check-not in config-file3 tests
 Date: Fri Sep 30 07:59:41 2022 +0200
 1 file changed, 26 insertions(+), 68 deletions(-)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134337/new/

https://reviews.llvm.org/D134337



More information about the cfe-commits mailing list