[PATCH] D134923: [clang][deps] Canonicalize module map path

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

Thanks, this LGTM with the test extension.



================
Comment at: clang/test/ClangScanDeps/modules-symlink-dir.c:33
+// CHECK-NOT: symlink-to-module
+// CHECK:            "[[PREFIX]]{{.}}module{{.}}F.framework{{.}}Modules{{.}}module.modulemap"
+// CHECK-NOT: symlink-to-module
----------------
Nit: I assume `{{.}}` is here to prevent issues with path separators on Windows. I'd prefer putting `/` here for readability and injecting `sed 's:\\\\\?:/:g'` into the RUN line like we do in rest of scanner tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134923/new/

https://reviews.llvm.org/D134923