[PATCH] D134923: [clang][deps] Canonicalize module map path

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added inline comments.


================
Comment at: clang/lib/Lex/ModuleMap.cpp:1307
+  // Do not canonicalize within the framework; the module map parser expects
+  // Modules/ not Versions/A/Modules.
+  if (llvm::sys::path::filename(Dir) == "Modules") {
----------------
Is that because the parser is looking for headers in `../Headers` and `../PrivateHeaders`? If so, would it make sense to make the parser smarter and canonicalize even framework paths here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134923/new/

https://reviews.llvm.org/D134923