[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

Thu Sep 29 13:29:21 PDT 2022

MaskRay added inline comments.

================
Comment at: clang/test/Driver/lit.local.cfg:8
-    ('%clang_cc1',
-     """*** Do not use 'clang -cc1' in Driver tests. ***""") )

----------------
MaskRay wrote:
> mgorny wrote:
> > MaskRay wrote:
> > > probinson wrote:
> > > > But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're not testing the driver!  Those tests really belong somewhere else, like Frontend.
> > > Sorry, I missed this change. I think a lot of `%clang -cc1` tests in test/Driver are actually wrong and should be moved to appropriate components.
> > > 
> > > The test/Driver part of this patch should be reverted.
> > I agree we don't want these tests there but 1) does anyone really volunteer to fix the problem, and 2) did the substitution override really prevent people from adding more wrong tests? I'm not against this, not at all. Just feel like we're fighting windmills here.
> There aren't many `%clang -cc1` tests in test/Driver. We can just notify people working on the components and hope that they will move tests to the appropriate components.
> 
> @python3kgae @yaxunl 
@beanz 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134880/new/

https://reviews.llvm.org/D134880