[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 29 12:20:01 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a think-o that I introduced with an earlier suggested change. I'm not super qualified for the CodeGen changes. They look correct to me, but @beanz would probably be able to better validate the correctness there.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:6597
+The ``SV_DispatchThreadID`` semantic, when applied to an input parameter,
+specifies a data binding to map global the thread offset within the Dispatch
+call (per dimension of the group) to the specified parameter.
----------------
Sorry, I had a typo in my earlier suggestion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133983/new/

https://reviews.llvm.org/D133983



More information about the cfe-commits mailing list