[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently
    Fangrui Song via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Thu Sep 29 12:12:44 PDT 2022
    
    
  
MaskRay added inline comments.
================
Comment at: clang/test/Driver/lit.local.cfg:8
-    ('%clang_cc1',
-     """*** Do not use 'clang -cc1' in Driver tests. ***""") )
 
----------------
probinson wrote:
> But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're not testing the driver!  Those tests really belong somewhere else, like Frontend.
Sorry, I missed this change. I think a lot of `%clang -cc1` tests in test/Driver are actually wrong and should be moved to appropriate components.
The test/Driver part of this patch should be reverted.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134880/new/
https://reviews.llvm.org/D134880
    
    
More information about the cfe-commits
mailing list