[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

Thu Sep 29 11:29:22 PDT 2022

MaskRay added a comment.

mips computed sysroot from GCCInstallation very early in 2013 rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 <https://reviews.llvm.org/rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9> and Android followed up in 2018 (D45291 <https://reviews.llvm.org/D45291>), but I am not sure this is the correct direction.
They are to support very special distributions. Hard coding the logic does not scale if we intend to support more Linux distributions.
I raised my concern on https://reviews.llvm.org/D134454#3824630 as well.

With https://reviews.llvm.org/D134337 (default configuration file) we should move the logic to use a default configuration file instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121445/new/

https://reviews.llvm.org/D121445