[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 29 11:14:21 PDT 2022


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:369
+  // Path = $GCCToolchainPath/csky-linux-gnuabiv2/libc
+  if (getTriple().isCSKY())
+    Path += "/libc";
----------------
If the `else` branch uses braces, the `then` branch needs brances as well.
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

I can fix this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134454/new/

https://reviews.llvm.org/D134454



More information about the cfe-commits mailing list