[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:1065-1080
+  StringRef EffectiveDriverMode;
+  if (CLOptions)
+    EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode);
+  if (EffectiveDriverMode.empty())
+    EffectiveDriverMode = ClangNameParts.DriverMode;
+
+  llvm::Triple EffectiveTriple =
----------------
mgorny wrote:
> This part is mostly proof-of-concept, I need to look into how to do this properly.
The next common mentions "second part" but it isn't very clear what "first part" and "second part" mean.
Perhaps repeat <triple>.cfg here and replace "second part" with "<mode>.cfg"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134337/new/

https://reviews.llvm.org/D134337