[PATCH] D134020: [clang][Interp] Handle enums

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added inline comments.


================
Comment at: clang/test/AST/Interp/enums.cpp:25
+  SIX = FIVE + 2,
+
+};
----------------
shafik wrote:
> Maybe some edge case values for enumerators like `__INT_MAX__  *2U +1U` (UINT_MAX) 
> 
> and 
> 
> ```
> enum E { // warning: enumeration values exceed range of largest integer [-Wenum-too-large]
>   E1 = -__LONG_MAX__ -1L,
>   E2 = __LONG_MAX__ *2UL+1UL 
> };
> ```
Hm, looks like that test broke one of the windows builders: https://lab.llvm.org/buildbot/#/builders/123/builds/13424 - are enums larger by default on Windows? What do you suggest to fix the test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134020/new/

https://reviews.llvm.org/D134020