[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

[Owen Pan via Phabricator via cfe-commits]

owenpan added a comment.

In D134329#3822028 <https://reviews.llvm.org/D134329#3822028>, @MyDeveloperDay wrote:

> I guess the clang-format check might come before any building of the code.

+1.

> You know if we relex the "Unknown" YAML option, this would go a long way not only to help us here but also to that situation where new options break people using older clang-format version.

Changing an unknown/misspelled-option error to a warning will also change the return code of clang-format. That would be unacceptable to a lot people, I believe.

In general, new options won't cause problems for people unless they add them to config files without updating clang-format. The situation with clang-format sources is very unique and rarely occurs, so it's probably better to just leave it as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134329/new/

https://reviews.llvm.org/D134329