[PATCH] D134369: [Clang] Support constexpr builtin fmax
Evgeny Shulgin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 28 16:46:09 PDT 2022
Izaron updated this revision to Diff 463715.
Izaron added a comment.
Rebase and fix windows __float128 failure
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134369/new/
https://reviews.llvm.org/D134369
Files:
clang/docs/LanguageExtensions.rst
clang/lib/AST/ExprConstant.cpp
clang/test/Sema/constant-builtins-fmax.cpp
Index: clang/test/Sema/constant-builtins-fmax.cpp
===================================================================
--- /dev/null
+++ clang/test/Sema/constant-builtins-fmax.cpp
@@ -0,0 +1,54 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+// expected-no-diagnostics
+
+constexpr double NaN = __builtin_nan("");
+constexpr double Inf = __builtin_inf();
+constexpr double NegInf = -__builtin_inf();
+
+#define FMAX_TEST_SIMPLE(T, FUNC) \
+ static_assert(T(6.7890) == FUNC(T(1.2345), T(6.7890))); \
+ static_assert(T(6.7890) == FUNC(T(6.7890), T(1.2345)));
+
+#define FMAX_TEST_NAN(T, FUNC) \
+ static_assert(Inf == FUNC(NaN, Inf)); \
+ static_assert(NegInf == FUNC(NegInf, NaN)); \
+ static_assert(0.0 == FUNC(NaN, 0.0)); \
+ static_assert(-0.0 == FUNC(-0.0, NaN)); \
+ static_assert(T(-1.2345) == FUNC(NaN, T(-1.2345))); \
+ static_assert(T(1.2345) == FUNC(T(1.2345), NaN)); \
+ static_assert(__builtin_isnan(FUNC(NaN, NaN)));
+
+#define FMAX_TEST_INF(T, FUNC) \
+ static_assert(Inf == FUNC(NegInf, Inf)); \
+ static_assert(Inf == FUNC(Inf, 0.0)); \
+ static_assert(Inf == FUNC(-0.0, Inf)); \
+ static_assert(Inf == FUNC(Inf, T(1.2345))); \
+ static_assert(Inf == FUNC(T(-1.2345), Inf));
+
+#define FMAX_TEST_NEG_INF(T, FUNC) \
+ static_assert(Inf == FUNC(Inf, NegInf)); \
+ static_assert(0.0 == FUNC(NegInf, 0.0)); \
+ static_assert(-0.0 == FUNC(-0.0, NegInf)); \
+ static_assert(T(-1.2345) == FUNC(NegInf, T(-1.2345))); \
+ static_assert(T(1.2345) == FUNC(T(1.2345), NegInf));
+
+#define FMAX_TEST_BOTH_ZERO(T, FUNC) \
+ static_assert(0.0 == FUNC(0.0, 0.0)); \
+ static_assert(0.0 == FUNC(-0.0, 0.0)); \
+ static_assert(0.0 == FUNC(0.0, -0.0)); \
+ static_assert(0.0 == FUNC(-0.0, -0.0));
+
+#define LIST_FMAX_TESTS(T, FUNC) \
+ FMAX_TEST_SIMPLE(T, FUNC) \
+ FMAX_TEST_NAN(T, FUNC) \
+ FMAX_TEST_INF(T, FUNC) \
+ FMAX_TEST_NEG_INF(T, FUNC) \
+ FMAX_TEST_BOTH_ZERO(T, FUNC)
+
+LIST_FMAX_TESTS(double, __builtin_fmax)
+LIST_FMAX_TESTS(float, __builtin_fmaxf)
+LIST_FMAX_TESTS((long double), __builtin_fmaxl)
+LIST_FMAX_TESTS(__fp16, __builtin_fmaxf16)
+#ifdef __FLOAT128__
+LIST_FMAX_TESTS(__float128, __builtin_fmaxf128)
+#endif
Index: clang/lib/AST/ExprConstant.cpp
===================================================================
--- clang/lib/AST/ExprConstant.cpp
+++ clang/lib/AST/ExprConstant.cpp
@@ -14021,6 +14021,20 @@
Result.copySign(RHS);
return true;
}
+
+ case Builtin::BI__builtin_fmax:
+ case Builtin::BI__builtin_fmaxf:
+ case Builtin::BI__builtin_fmaxl:
+ case Builtin::BI__builtin_fmaxf16:
+ case Builtin::BI__builtin_fmaxf128: {
+ APFloat RHS(0.);
+ if (!EvaluateFloat(E->getArg(0), Result, Info) ||
+ !EvaluateFloat(E->getArg(1), RHS, Info))
+ return false;
+ if (Result.isNaN() || RHS > Result)
+ Result = RHS;
+ return true;
+ }
}
}
Index: clang/docs/LanguageExtensions.rst
===================================================================
--- clang/docs/LanguageExtensions.rst
+++ clang/docs/LanguageExtensions.rst
@@ -4660,6 +4660,7 @@
* ``__builtin_ffs``
* ``__builtin_ffsl``
* ``__builtin_ffsll``
+* ``__builtin_fmax``
* ``__builtin_fpclassify``
* ``__builtin_inf``
* ``__builtin_isinf``
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134369.463715.patch
Type: text/x-patch
Size: 3485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220928/7663e850/attachment.bin>
More information about the cfe-commits
mailing list