[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 10:28:57 PDT 2022


nickdesaulniers added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:376
+  if (getTriple().isMIPS()) {
+    const Multilib &Multilib = GCCInstallation.getMultilib();
+    Path = Path + "/libc" + Multilib.osSuffix();
----------------
nickdesaulniers wrote:
> It might be worthwhile to have the variable be
> ```
> std::string OSSuffix = GCCInstallation.getMultilib().osSuffix();
> ```
> rather than the `Multilib` object.
err... I guess a `std::string&`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134454/new/

https://reviews.llvm.org/D134454



More information about the cfe-commits mailing list