[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 09:50:17 PDT 2022


aaron.ballman added a comment.

In D134578#3821301 <https://reviews.llvm.org/D134578#3821301>, @ayzhao wrote:

> In D134578#3821178 <https://reviews.llvm.org/D134578#3821178>, @ilya-biryukov wrote:
>
>> Is this the only thing that blocks D53847 <https://reviews.llvm.org/D53847>?
>> I suggest to stamp this if so (happy to do it myself). In case @ChuanqiXu will have comments we can address them in post-commit review.
>
> SG, I'll go ahead and land this and D53847 <https://reviews.llvm.org/D53847>.
>
> TBH this patch was probably trivial enough to not require

FWIW, the changes here LGTM and I agree that this probably didn't require a review given the trivial nature of the changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134578/new/

https://reviews.llvm.org/D134578



More information about the cfe-commits mailing list