[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 06:21:49 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: clang/test/AST/Interp/records.cpp:52
 static_assert(!ints2.c, "");
 
 constexpr Ints ints3 = getInts();
----------------
tbaeder wrote:
> aaron.ballman wrote:
> > Can you think of a reasonable way for us to test that you're handling the RVO pointer properly?
> I think this is tested already by any function returning a non-primitive value, i.e. a struct or an array, e.g. `getInts()` above.
Oh derp, you're right!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134175/new/

https://reviews.llvm.org/D134175



More information about the cfe-commits mailing list