[PATCH] D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value

[Yonghong Song via Phabricator via cfe-commits]

yonghong-song added a comment.

In D134705#3818657 <https://reviews.llvm.org/D134705#3818657>, @dblaikie wrote:

> SGTM - could you also add some CHECKs in the test that show the enumeration was added to the enumerators list on the CU (& you can probably test with just one enumerator - don't need two in each test for instance)

Okay, will do.

> & I'm not quite following - what's the difference between the two cases being tested? Oh, I guess the second has implicit conversions in the case parameters? Fair enough, maybe would benefit from some comments.

Yes, the first is without implicit conversion and the second is with implicit conversion. I will add some comments to clarify it in the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134705/new/

https://reviews.llvm.org/D134705