[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 23:03:31 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/Driver.cpp:6195
+
+  assert(false && "Unhandled Mode");
+  return "clang";
----------------
MaskRay wrote:
> If the switch covers all enum members, we typically use llvm_unreachable to work around a GCC -Wswitch warning.
> Clang correctly knows all branches are covered and do not need `llvm_unreachable`
`llvm_unreachable`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134337/new/

https://reviews.llvm.org/D134337



More information about the cfe-commits mailing list