[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

Michael Wyman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 13:59:14 PDT 2022


mwyman added a comment.

In D86049#3818981 <https://reviews.llvm.org/D86049#3818981>, @plotfi wrote:

> @ahatanak I can revive some of what I was working on from https://reviews.llvm.org/D86049?id=285923 if we think we need a thunk for the checks as @rjmccall mentioned.

I believe the generated direct methods already handle the null checks and class init in `CGObjCCommonMac::GenerateDirectMethodPrologue`, meaning the thunks aren't strictly necessary for the callee to handle them.

Could the thunks instead allow us to have publicly-visible mangled names (something akin to the new selector stubs `_objc_msgSend$selectorName` but for `_objc_direct$Class_selectorName`) while leaving the actual impl name alone, letting the stack traces see normal ObjC symbol names?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86049/new/

https://reviews.llvm.org/D86049



More information about the cfe-commits mailing list