[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 13:01:03 PDT 2022


rnk added a comment.

In D134456#3818952 <https://reviews.llvm.org/D134456#3818952>, @aaron.ballman wrote:

> I think that would be reasonable to at least consider; the default behavior can be "the attribute wins" and this gives users an escape hatch to say "no, I trust PGO more, let that win instead".

Right, but that's a policy change. We'd need to update docs, update release notes, and all of that. We'll need this fix in any case for the mode where PGO wins, which will remain long term for the users that rely on it.

What commitments can we make to land this fix without making a policy change, which is quite a great deal of work (RFC, docs, notes, etc)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134456/new/

https://reviews.llvm.org/D134456



More information about the cfe-commits mailing list