[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

Tue Sep 27 10:55:55 PDT 2022

plotfi added a comment.

In D86049#3818435 <https://reviews.llvm.org/D86049#3818435>, @mwyman wrote:

> In D86049#3816006 <https://reviews.llvm.org/D86049#3816006>, @plotfi wrote:
>
>> @dmaclach @ahatanak @mwyman How do things look from here? Do you want something for properties as well or would it be ok if we did this in a later commit?
>
> Huh, for some reason I thought when I'd last poked at using the `visibility` attribute it wasn't allowed on ObjC methods, which is why I'd suggested adding the enum on `objc_direct`, but as that no longer appears to be the case yes I like this approach better.

@dmaclach @mwyman  I am also very happy with the fact that we can just reuse the regular `visibility` attribute. In the future we can decide on revised behavior for `hasMethodVisibilityDefault`.

@ahatanak Do you have feedback on this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86049/new/

https://reviews.llvm.org/D86049